Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new AWS Europe (Zurich) Region eu-central-2 #27814

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Support new AWS Europe (Zurich) Region eu-central-2 #27814

merged 6 commits into from
Nov 15, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 15, 2022 •
edited
Loading

Description

Adds support for the new AWS Region eu-central-2.

Relations

Closes #27720.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudTrailServiceAccountDataSource_' PKG=cloudtrail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudtrail/... -v -count 1 -parallel 2  -run=TestAccCloudTrailServiceAccountDataSource_ -timeout 180m
=== RUN   TestAccCloudTrailServiceAccountDataSource_basic
=== PAUSE TestAccCloudTrailServiceAccountDataSource_basic
=== RUN   TestAccCloudTrailServiceAccountDataSource_region
=== PAUSE TestAccCloudTrailServiceAccountDataSource_region
=== CONT  TestAccCloudTrailServiceAccountDataSource_basic
=== CONT  TestAccCloudTrailServiceAccountDataSource_region
--- PASS: TestAccCloudTrailServiceAccountDataSource_region (13.35s)
--- PASS: TestAccCloudTrailServiceAccountDataSource_basic (13.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	20.158s
% make testacc TESTARGS='-run=TestAccELBV2HostedZoneIDDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2HostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBV2HostedZoneIDDataSource_basic
=== PAUSE TestAccELBV2HostedZoneIDDataSource_basic
=== CONT  TestAccELBV2HostedZoneIDDataSource_basic
--- PASS: TestAccELBV2HostedZoneIDDataSource_basic (41.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	46.190s
% make testacc TESTARGS='-run=TestAccELBHostedZoneIDDataSource_' PKG=elb ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 2  -run=TestAccELBHostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (21.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	26.234s
% make testacc TESTARGS='-run=TestAccS3BucketDataSource_basic' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketDataSource_basic -timeout 180m
=== RUN   TestAccS3BucketDataSource_basic
=== PAUSE TestAccS3BucketDataSource_basic
=== CONT  TestAccS3BucketDataSource_basic
--- PASS: TestAccS3BucketDataSource_basic (21.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	26.400s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR. and removed service/s3 Issues and PRs that pertain to the s3 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. labels Nov 15, 2022
@github-actions github-actions bot added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service. labels Nov 15, 2022
jar-b
jar-b approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccCloudTrailServiceAccountDataSource_' PKG=cloudtrail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudtrail/... -v -count 1 -parallel 2  -run=TestAccCloudTrailServiceAccountDataSource_ -timeout 180m
=== RUN   TestAccCloudTrailServiceAccountDataSource_basic
=== PAUSE TestAccCloudTrailServiceAccountDataSource_basic
=== RUN   TestAccCloudTrailServiceAccountDataSource_region
=== PAUSE TestAccCloudTrailServiceAccountDataSource_region
=== CONT  TestAccCloudTrailServiceAccountDataSource_basic
=== CONT  TestAccCloudTrailServiceAccountDataSource_region
--- PASS: TestAccCloudTrailServiceAccountDataSource_region (10.88s)
--- PASS: TestAccCloudTrailServiceAccountDataSource_basic (10.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 13.530s
$ make testacc TESTARGS='-run=TestAccELBV2HostedZoneIDDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2HostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBV2HostedZoneIDDataSource_basic
=== PAUSE TestAccELBV2HostedZoneIDDataSource_basic
=== CONT  TestAccELBV2HostedZoneIDDataSource_basic
--- PASS: TestAccELBV2HostedZoneIDDataSource_basic (34.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      37.064s
$ make testacc TESTARGS='-run=TestAccELBHostedZoneIDDataSource_' PKG=elb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 2  -run=TestAccELBHostedZoneIDDataSource_ -timeout 180m
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (18.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        21.134s
$ make testacc TESTARGS='-run=TestAccS3BucketDataSource_basic' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketDataSource_basic -timeout 180m
=== RUN   TestAccS3BucketDataSource_basic
=== PAUSE TestAccS3BucketDataSource_basic
=== CONT  TestAccS3BucketDataSource_basic
--- PASS: TestAccS3BucketDataSource_basic (19.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 22.302s

@ewbankkit ewbankkit merged commit 5f424ec into main Nov 15, 2022
@ewbankkit ewbankkit deleted the f-eu-central-2 branch November 15, 2022 16:24
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 15, 2022
github-actions bot pushed a commit that referenced this pull request Nov 15, 2022
Update CHANGELOG.md for #27814
eee1353
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.

New AWS Region: eu-central-2
2 participants
@ewbankkit @jar-b